[None][test] Update QA test list of RTX 6K. - #14421
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR reduces the RTX 6K QA test list by removing 52 test entries across four changes: eliminating two accuracy tests, consolidating Llama4 variants to specific tensor/expert parallel configurations, removing encoder and multimodal tests, and dropping disaggregated-serving tests for TinyLlama. ChangesQA Test List Curation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
|
/bot run --skip-test |
|
PR_Github #49795 [ run ] triggered by Bot. Commit: |
Signed-off-by: Pamela <179191831+pamelap-nvidia@users.noreply.github.com>
b0554bd to
55aa6e7
Compare
Signed-off-by: Pamela <179191831+pamelap-nvidia@users.noreply.github.com>
|
PR_Github #49795 [ run ] completed with state |
Signed-off-by: Pamela <179191831+pamelap-nvidia@users.noreply.github.com>
cee8beb to
1cbc11a
Compare
|
/bot run --stage-list "" |
1cbc11a to
cee8beb
Compare
|
PR_Github #49834 [ run ] triggered by Bot. Commit: |
|
PR_Github #49834 [ run ] completed with state |
|
I think this PR is out-of-date, @pamelap-nvidia Could you please help confirm if we can close this PR for now? |
| accuracy/test_llm_api_pytorch.py::TestLlama3_3_70BInstruct::test_fp8_eagle3_tp8[eagle3_one_model=False-torch_compile=False] | ||
| accuracy/test_llm_api_pytorch.py::TestLlama3_3_70BInstruct::test_fp8_eagle3_tp8[eagle3_one_model=False-torch_compile=True] | ||
| accuracy/test_llm_api_pytorch.py::TestPhi4MiniInstruct::test_auto_dtype | ||
| accuracy/test_llm_api_pytorch.py::TestLlama4MaverickInstruct::test_auto_dtype[tp8ep8-cuda_graph=True] |
There was a problem hiding this comment.
llama4 is obsoleted, do we still need to test it?
|
close this MR, as it is out-of date |
Summary by CodeRabbit
Description
Reduce the test list of RTX 6K
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.